Commit Graph

151 Commits (f8f2da25ab83779f5a9521f327987d5e7bace85f)

Author SHA1 Message Date
Philipp Hagemeister 21bfcd3d6e [postprocessor/ffmpeg] Add support for flac
Requested at http://stackoverflow.com/q/42828041/35070
Sergey M․ 0f57447de7
[postprocessor/ffmpeg] Add mising space (closes )
Yen Chi Hsuan ec85ded83c
Fix "invalid escape sequences" error on Python 3.6
Yen Chi Hsuan 8e2915d70b
Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails"
This reverts commit 7360db05b4.

This commit was added as an attempt to fix . Unfortunately, the fix
is completely wrong. As reported on , embedded thumbnails are not
displayed in VLC, and Se7en on IRC reports that the embedded thumbnail
misleads mpv as well.

The correct way is using -attachment of ffmpeg, while the current
run_ffmpeg_multiple_files API can't handle it cleanly.
Sergey M․ 0b94dbb115
[postprocessor/ffmpeg] PEP 8
Pierre Mdawar 2273e2c530 [postprocessor/ffmpeg] Return correct filepath and ext in updated information in FFmpegExtractAudioPP
Return correct audio's filepath and ext instead of the video's when extracting audio and audio file already exists.
Déstin Reed dcdb292fdd
Unify coding cookie
Yen Chi Hsuan efa97bdcf1
Move write_xattr to utils.py
There are some other places that use xattr functions. It's better to
move it to a common place so that others can use it.
Remita Amine 30d9e20938 [postprocessor/ffmpeg] apply FFmpegFixupM3u8PP only for videos with aac codec()
Sergey M․ 25dd58ca6a
[metadatafromtitle] Remove unused exception class
nyorain 5e42f8a0ad
Make --metadata-from-title non fatal
Output a warning if the metadata can't be parsed from the title (and don't write any metadata) instead of raising a critical error.
Yen Chi Hsuan 23495d6a39
Revert "[ffmpeg] Fix embedding subtitles ()"
This reverts commit ccff2c404d.

Fixes .

The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:

opts = [
    '-map', '0:v?',
    '-c:v', 'copy',
    '-map', '0:a?',
    '-c:a', 'copy',
    # other options...
]

Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in  no longer serves
problematic files, so I can't test it. I'll reopen  and wait for
another example so that I can test '-ignore_unknown'.
Yen Chi Hsuan 5b6a74856b Merge pull request from reyyed/issue#9063fix
[ffmpeg] Fix embedding subtitles ()
Yen Chi Hsuan 702ccf2dc0
[compat] Rename shlex_quote and remove unused subprocess_check_output
Sergey M․ 4bd143a3a0
[postprocessor/ffmpeg] Simplify metadata preparation and add track related metafields (Closes )
Wang Jun Tham ccff2c404d [ffmpeg] Fix embedding subtitles ()
Changed command line parameters for ffmpeg when embedding subtitles.
Changed to ‘-map 0:v -c:v copy -map 0:a -c:a copy’
remitamine b9f2fdd37f [ffmpeg] Clarify rationale for pipe(-) exclusion in _ffmpeg_filename_argument
remitamine d868f43c58 [ffmpeg] check for - file name in _ffmpeg_filename_argument
remitamine 0750b2491f [ffmpeg] try to convert tt subtitles usng dfxp2srt
Sergey M․ 40025ee2a3 [postprocessort/ffmpeg] Allow embedding webvtt into webm (Closes )
remitamine 2e7e561c1d Merge pull request from remitamine/ffmpegfd
[downloader/external] Add FFmpegFD
remitamine a755f82549 [ffmpeg] convert format ext to ffmpeg output formats codes
remitamine 090eb8e25f Merge pull request from remitamine/m3u8-fixup
Add fixup for media files produced by HlsNative downloader(fixes )
Yen Chi Hsuan e9c0cdd389 [jython] Introduce compat_os_name
os.name is always 'java' on Jython
remitamine f17f86513e Add fixup for media files produced by HlsNative downloader(fixes )
Yen Chi Hsuan 7360db05b4 [postprocessor/embedthumbnail] Allow mkv to embed thumbnails
Fixes 
Sergey M․ 611c1dd96e [refactor] Single quotes consistency
Jaime Marquínez Ferrándiz d4f8e83404 [FFmpegSubtitlesConvertorPP] remove unused variable
Jaime Marquínez Ferrándiz 7b8b007cd9 [FFmpegSubtitlesConvertorPP] remove intermediate srt files
Jaime Marquínez Ferrándiz 3547d26587 [FFmpegSubtitlesConvertorPP] correctly update the extension (fixes )
Jaime Marquínez Ferrándiz 7e62c2eb6d [FFmpegSubtitlesConvertorPP] fix not working when srt is used as the intermediate format between ttml/dfxp and other format
It was trying to use the ttml/dfxp file with ffmpeg, which doesn't have support for them.
I broke it in e04398e397.
remitamine 7d3a035ee0 [ffmpeg] check for m3u8 protocol in FFmpegMetadataPP
remitamine 593e0f43b4 [ffmpeg] fix condition(fixes )
remitamine 6fba62c87a [ffmpeg] fix adding metadata when using --hls-prefer-native()
remitamine fae45ede08 Merge pull request from remitamine/m3u8_metadata
[ffmpeg] fix adding metadata when using m3u8_native(fixes )
Jaime Marquínez Ferrándiz e04398e397 [FFmpegSubtitlesConvertorPP] delete old subtitle files (fixes )
remitamine cf57433bbd [ffmpeg] fix adding metadata when using m3u8_native(fixes )
Juan M Martínez 374c761e77 [FFmpegPostProcessor] Default of prefer ffmpeg
When no `downloader` is passed to `FFmpegPostProcessor`
an exception was raised trying to get the prefer ffmpeg param.

    AttributeError: 'NoneType' object has no attribute 'params'

This fixes and defaults to `False`.
Sergey M․ deb85c32bb [postprocessor/ffmpeg] Use ffmpeg as prefix since it's used all over the places (Closes )
Jaime Marquínez Ferrándiz 8a7bbd1606 [postprocessor/ffmpeg] Always use the 'file:' protocol for filenames (fixes )
If the filename contains ':' it is interpreted as a protocol.
It also handles filenames starting with '-'.
Jaime Marquínez Ferrándiz 3026164b16 [postprocessor/common] Use 'self._downloader.params' instead of 'self.params'
'self.params' is not defined
Sergey M․ 6270239a6d [postprocessor/common] Use generalized cli option converters
Jaime Marquínez Ferrándiz 9750e7d70e [postprocessor/ffmpeg] Don't use '[youtube] ...' in messages
Because it can be used for other extractors.
Sergey M․ 15006fedb9 [postprocessor/ffmpeg] Spread postprocessor args usage on all ffmpeg extractors
Sergey M․ e35b23f54d [postprocessor/common] Improve postprocessor args fetching and clarify doc
Sergey M․ f72b0a6032 Revert xvid to avi and make docs to be similar to existing external downloader option
Sergey M․ ac9ed061ec Merge branch 'master' of https://github.com/aurium/youtube-dl into aurium-master
Aurélio A. Heckert aa5d9a79d6 Simplify `postprocessor_args` transmission to PP base class
* Remove `extra_cmd_args` transmission from sub to super class.
* Simplify params transmission through `downloader.params`.
Aurélio A. Heckert 1866432db7 Rename --pp-params to --postprocessor-args and access value as super class attribute
Yen Chi Hsuan 396726244a [utils/ffmpeg] Move ISO 639 related codes to utils