FFmpegEmbedSubtitlePP: remove the subtitle files if '--keep-video' is not given (closes #5435)

10 years ago · 14523ed969
parent 592e97e855
commit 14523ed969
1 changed files with 3 additions and 2 deletions
--- a/youtube_dl/postprocessor/ffmpeg.py
+++ b/youtube_dl/postprocessor/ffmpeg.py
@ -513,7 +513,8 @@ class FFmpegEmbedSubtitlePP(FFmpegPostProcessor):

        sub_langs = list(subtitles.keys())
        filename = information['filepath']
-        input_files = [filename] + [subtitles_filename(filename, lang, sub_info['ext']) for lang, sub_info in subtitles.items()]
+        sub_filenames = [subtitles_filename(filename, lang, sub_info['ext']) for lang, sub_info in subtitles.items()]
+        input_files = [filename] + sub_filenames

        opts = [
            '-map', '0',
@ -535,7 +536,7 @@ class FFmpegEmbedSubtitlePP(FFmpegPostProcessor):
        os.remove(encodeFilename(filename))
        os.rename(encodeFilename(temp_filename), encodeFilename(filename))

-        return [], information
+        return sub_filenames, information


 class FFmpegMetadataPP(FFmpegPostProcessor):