mirror of https://github.com/yt-dlp/yt-dlp
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
a9ac178eb1
I use yt-dlp on Windows writing to a Linux system via SMB over a 10GbE connection and downloading via 400 Mbps cable internet. I have observed that downloads often seem to start very fast (40+ MiB/sec) but then throttle down to 8-20 MiB/sec. I also observed a large amount of disk thrashing for such a large array and small amount of data that's supposedly being written sequentially. The problem is two-fold. Downloaded fragments are stored using a very short-lived *-FragX file, then immediately appended to the stream upon fragment completion, and deleted. Both operations use small write buffers. When the OS write buffers start to flush, the two sets of writes plus the large number of writes start to force competition to complete the queued writes in different areas of the volume. Python defaults to sending writes at the underlying device's "block size" or a fallback to io.DEFAULT_BUFFER_SIZE. In practical terms, this means a write buffer of 4096 or 8192 bytes. This commit increases most write buffers to 65536 (64 KiB) using the open() buffering=X option, significantly speeding up writes of larger chunks of data and reducing potential fragmentation in low disk space conditions. With these changes, I consistently see fast downloads and the array thrashing is noticeably lessened. |
4 months ago | |
|---|---|---|
| .. | ||
| __pyinstaller | 1 year ago | |
| compat | 5 months ago | |
| dependencies | 5 months ago | |
| downloader | 4 months ago | |
| extractor | 4 months ago | |
| networking | 7 months ago | |
| postprocessor | 4 months ago | |
| utils | 4 months ago | |
| YoutubeDL.py | 4 months ago | |
| __init__.py | 4 months ago | |
| __main__.py | 1 year ago | |
| aes.py | 4 months ago | |
| cache.py | 10 months ago | |
| cookies.py | 4 months ago | |
| jsinterp.py | 8 months ago | |
| minicurses.py | ||
| options.py | 5 months ago | |
| plugins.py | 4 months ago | |
| socks.py | 10 months ago | |
| update.py | 4 months ago | |
| version.py | 4 months ago | |
| webvtt.py | 10 months ago | |