From ded67f90ca716295ee51c20119e5396fe1e67d01 Mon Sep 17 00:00:00 2001 From: Christopher Usher Date: Wed, 30 Oct 2019 22:58:55 +0000 Subject: [PATCH] fixes to the error handling as suggested by ekim --- backfiller/backfiller/main.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/backfiller/backfiller/main.py b/backfiller/backfiller/main.py index 986f4a5..be0a957 100644 --- a/backfiller/backfiller/main.py +++ b/backfiller/backfiller/main.py @@ -286,10 +286,11 @@ class BackfillerManager(object): # ignore error when file is already deleted if e.errno == errno.ENOENT: self.logger.warn('{} already deleted'.format(path)) - # warn if not empty (will try to delete folder again next time) elif e.errno == errno.ENOTEMPTY: self.logger.warn('Failed to delete non-empty folder {}'.format(path)) + else: + raise else: self.logger.info('{} deleted'.format(path)) @@ -331,7 +332,7 @@ class BackfillerManager(object): if self.run_once: break - # if get_nodes() raises an error, this will deletes will not occur + # note that if get_nodes() raises an error, then deletes will not occur if self.delete_old and self.start: try: self.delete_hours()