From ff18c7df54ca2fd5578dc3b38bf655c7a76c17e8 Mon Sep 17 00:00:00 2001 From: Mike Lang Date: Sun, 3 Nov 2019 01:21:59 -0700 Subject: [PATCH] backfiller: Fix issue with tracking metrics after get_nodes() failure There isn't an easy, clean way to pass in the DB hostname there, and neither label is very valuable. Let's just drop it entirely. --- backfiller/backfiller/main.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/backfiller/backfiller/main.py b/backfiller/backfiller/main.py index 1a1f742..7463379 100644 --- a/backfiller/backfiller/main.py +++ b/backfiller/backfiller/main.py @@ -45,7 +45,6 @@ hash_mismatches = prom.Counter( node_list_errors = prom.Counter( 'node_list_errors', 'Number of errors fetching a list of nodes', - ['filename', 'database'], ) backfill_errors = prom.Counter( @@ -321,7 +320,7 @@ class BackfillerManager(object): failures += 1 delay = common.jitter(TIMEOUT * 2**failures) self.logger.exception('Getting nodes failed. Retrying in {:.0f} s'.format(delay)) - node_list_errors.labels(filename=self.node_file).inc() + node_list_errors.inc() self.stopping.wait(delay) continue exisiting_nodes = set(self.workers.keys())