wubloader

Commit Graph

Author	SHA1	Message	Date
Mike Lang	6815924097	Fix some bugs and linter errors introduced by backfiller I ran `pyflakes` on the repo and found these bugs: ``` ./common/common.py:289: undefined name 'random' ./downloader/downloader/main.py:7: 'random' imported but unused ./backfiller/backfiller/main.py:150: undefined name 'variant' ./backfiller/backfiller/main.py:158: undefined name 'timedelta' ./backfiller/backfiller/main.py:171: undefined name 'sort' ./backfiller/backfiller/main.py:173: undefined name 'sort' ``` (ok, the "imported but unused" one isn't a bug, but the rest are) This fixes those, as well as a further issue I saw with sorting of hours. Iterables are not sortable. As an obvious example, what if your iterable was infinite? As a result, any attempt to sort an iterable that is not already a friendly type like a list or tuple will result in an error. We avoid this by coercing to list, fully realising the iterable and putting it into a form that python will let us sort. It also avoids the nasty side-effect of mutating the list that gets passed into us, which the caller may not expect. Consider this example: ``` >>> my_hours = ["one", "two", "three"] >>> print my_hours ["one", "two", "three"] >>> backfill_node(base_dir, node, stream, variants, hours=my_hours, order='forward') >>> print my_hours ["one", "three", "two"] ``` Also, one of the linter errors was non-trivial to fix - we were trying to get a list of hours (which is an api call for a particular variant), but at a time when we weren't dealing with a single variant. My solution was to get a list of hours for ALL variants, and take the union.	6 years ago
Christopher Usher	fec0975d18	fixed white space and the like	6 years ago
Christopher Usher	3cdfaad664	moved rename, ensure_directory and jitter to common Move a few useful functions in downloader used in the backfiller to common	6 years ago
Mike Lang	6fa74608fb	common: Improve some docs to note types of things that are ambiguous	6 years ago
Mike Lang	3bbe1ed32d	Prefer longer duration on multiple segments	6 years ago
Christopher Usher	4981c6521b	Merge pull request #5 from ekimekim/mike/restreamer/initial Initial work on restreamer	6 years ago
Mike Lang	75c9793eac	Remove central config file as it's more trouble than it's worth Simpler and easier for testing to stick to configuration via CLI args. We'll worry about deployment later.	6 years ago
Mike Lang	0df8288013	common: Implement code for parsing paths and picking the best sequence of segments This is needed by both the restreamer and the cutter, hence its inclusion in common. The algorithm is pretty simple - it takes the 'best' segment per start time by full first, then length of partial. All the other complexity is mainly just around detecting and reporting holes, and being inclusive of start/end points.	6 years ago
Christopher Usher	8f462f5926	Fixed format_bustime docsting	6 years ago
Christopher Usher	4c22edf2e6	Fixed negative times in format_bustime	6 years ago
Mike Lang	d7641aecf5	common: Fix bugs and issues with bustime utils	6 years ago
Mike Lang	048277b003	common: Basic config and bustime code	6 years ago
Mike Lang	a361ab7a63	Add a common package for common bits in multiple components	6 years ago

13 Commits (bae039977b8ea28e3c54a97e82ff0459d701b60a)