wubloader

You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

History

Mike Lang 10cca18922 Fix a deadlock due to signal interactions with prometheus client The prometheus client uses a threading.Lock() to prevent shared access to certain metric state. This lock is taken as part of doing collection, as well as during metric.labels(). We hit a deadlock where our stack sampler signal arrived during a collection, when the lock was held. This meant that flamegraph.labels() blocked forever, and the lock was never released, hanging all metrics collection. Our solution is a hack, which is to reach into the internals of our metric object and replace its lock with a dummy one. This is reasonably safe, but only as long as the prometheus_client internal structure doesn't change signfigiantly.	6 years ago
..
common	Fix a deadlock due to signal interactions with prometheus client	6 years ago
setup.py	Fix a deadlock due to signal interactions with prometheus client	6 years ago

Mike Lang 10cca18922 Fix a deadlock due to signal interactions with prometheus client

The prometheus client uses a threading.Lock() to prevent shared access to
certain metric state. This lock is taken as part of doing collection, as well
as during metric.labels().

We hit a deadlock where our stack sampler signal arrived during a collection,
when the lock was held. This meant that flamegraph.labels() blocked forever,
and the lock was never released, hanging all metrics collection.

Our solution is a hack, which is to reach into the internals of our metric object
and replace its lock with a dummy one. This is reasonably safe, but only as long as
the prometheus_client internal structure doesn't change signfigiantly.

common

Fix a deadlock due to signal interactions with prometheus client

setup.py

Fix a deadlock due to signal interactions with prometheus client