Eslint lsp and fix an nvim-tree issue

lua/core/keymaps/async/project-tree.lua

@@ -11,8 +11,14 @@ return function(buffer)
     nowait = true
   })
 
+  --[[
+  --  WARN The docs tell us to call default_on_attach
+  --  but doing it causes issues on git commits or when
+  --  no file is loaded
+  --]]
+
   -- default mappings
-  api.config.mappings.default_on_attach(buffer)
+  -- api.config.mappings.default_on_attach(buffer)
 
   nmap('<leader><space>', api.tree.toggle, 'File Tree')
   nmap('t', api.node.open.tab, 'Toggle Node')

lua/core/settings/init.lua

@@ -49,3 +49,11 @@ vim.o.completeopt = 'menuone,noselect'
 
 -- NOTE: You should make sure your terminal supports this
 vim.o.termguicolors = true
+
+vim.diagnostic.config({
+  virtual_text = false
+})
+
+-- Show line diagnostics automatically in hover window
+vim.o.updatetime = 250
+vim.cmd [[autocmd CursorHold,CursorHoldI * lua vim.diagnostic.open_float(nil, {focus=false})]]

lua/core/setup/language-servers.lua

@@ -3,6 +3,7 @@ local servers = {
   -- gopls = {},
   -- pyright = {},
   -- rust_analyzer = {},
+  eslint = {},
   tsserver = {},
 
   lua_ls = {