[soundcloud] Always add streaming formats

youtube_dl/extractor/soundcloud.py

@@ -124,45 +124,46 @@ class SoundcloudIE(InfoExtractor):
             'description': info['description'],
             'thumbnail': thumbnail,
         }
+        formats = []
         if info.get('downloadable', False):
             # We can build a direct link to the song
             format_url = (
                 'https://api.soundcloud.com/tracks/{0}/download?client_id={1}'.format(
                     track_id, self._CLIENT_ID))
-            result['formats'] = [{
+            formats.append({
                 'format_id': 'download',
                 'ext': info.get('original_format', 'mp3'),
                 'url': format_url,
                 'vcodec': 'none',
-            }]
+                'preference': 10,
-        else:
+            })
-            # We have to retrieve the url
+
-            streams_url = ('http://api.soundcloud.com/i1/tracks/{0}/streams?'
+        # We have to retrieve the url
-                'client_id={1}&secret_token={2}'.format(track_id, self._IPHONE_CLIENT_ID, secret_token))
+        streams_url = ('http://api.soundcloud.com/i1/tracks/{0}/streams?'
-            stream_json = self._download_webpage(
+            'client_id={1}&secret_token={2}'.format(track_id, self._IPHONE_CLIENT_ID, secret_token))
-                streams_url,
+        stream_json = self._download_webpage(
-                track_id, 'Downloading track url')
+            streams_url,
-
+            track_id, 'Downloading track url')
-            formats = []
+
-            format_dict = json.loads(stream_json)
+        format_dict = json.loads(stream_json)
-            for key, stream_url in format_dict.items():
+        for key, stream_url in format_dict.items():
-                if key.startswith('http'):
+            if key.startswith('http'):
-                    formats.append({
+                formats.append({
-                        'format_id': key,
+                    'format_id': key,
-                        'ext': ext,
+                    'ext': ext,
-                        'url': stream_url,
+                    'url': stream_url,
-                        'vcodec': 'none',
+                    'vcodec': 'none',
-                    })
+                })
-                elif key.startswith('rtmp'):
+            elif key.startswith('rtmp'):
-                    # The url doesn't have an rtmp app, we have to extract the playpath
+                # The url doesn't have an rtmp app, we have to extract the playpath
-                    url, path = stream_url.split('mp3:', 1)
+                url, path = stream_url.split('mp3:', 1)
-                    formats.append({
+                formats.append({
-                        'format_id': key,
+                    'format_id': key,
-                        'url': url,
+                    'url': url,
-                        'play_path': 'mp3:' + path,
+                    'play_path': 'mp3:' + path,
-                        'ext': ext,
+                    'ext': ext,
-                        'vcodec': 'none',
+                    'vcodec': 'none',
-                    })
+                })
 
             if not formats:
                 # We fallback to the stream_url in the original info, this