Correct detect_executables on Windows (Closes #447, #457)

youtube_dl/PostProcessor.py

@@ -71,13 +71,14 @@ class FFmpegExtractAudioPP(PostProcessor):
 
 	@staticmethod
 	def detect_executables():
-		available = {'avprobe' : False, 'avconv' : False, 'ffmpeg' : False, 'ffprobe' : False}
+		def executable(exe):
-		for path in os.environ["PATH"].split(os.pathsep):
+			try:
-			for program in available.keys():
+				subprocess.check_output([exe, '-version'])
-				exe_file = os.path.join(path, program)
+			except OSError:
-				if os.path.isfile(exe_file) and os.access(exe_file, os.X_OK):
+				return False
-					available[program] = exe_file
+			return exe
-		return available
+		programs = ['avprobe', 'avconv', 'ffmpeg', 'ffprobe']
+		return dict((program, executable(program)) for program in programs)
 
 	def get_audio_codec(self, path):
 		if not self._exes['ffprobe'] and not self._exes['avprobe']: return None