[utils] `base_url`: URL paths can contain `&` (#4841)

Authored by: elyse0 Closes #4187
3 years ago · 7657ec7ed6
parent 07a1250e0e
commit 7657ec7ed6
2 changed files with 2 additions and 1 deletions
--- a/test/test_utils.py
+++ b/test/test_utils.py
@ -566,6 +566,7 @@ class TestUtil(unittest.TestCase):
        self.assertEqual(base_url('http://foo.de/bar/'), 'http://foo.de/bar/')
        self.assertEqual(base_url('http://foo.de/bar/baz'), 'http://foo.de/bar/')
        self.assertEqual(base_url('http://foo.de/bar/baz?x=z/x/c'), 'http://foo.de/bar/')
+        self.assertEqual(base_url('http://foo.de/bar/baz&x=z&w=y/x/c'), 'http://foo.de/bar/baz&x=z&w=y/x/')

    def test_urljoin(self):
        self.assertEqual(urljoin('http://foo.de/', '/a/b/c.txt'), 'http://foo.de/a/b/c.txt')
--- a/yt_dlp/utils.py
+++ b/yt_dlp/utils.py
@ -2479,7 +2479,7 @@ def url_basename(url):


 def base_url(url):
-    return re.match(r'https?://[^?#&]+/', url).group()
+    return re.match(r'https?://[^?#]+/', url).group()


 def urljoin(base, path):