thrimbletrimmer: Validate chapter titles are ascii only

We are not sure what characters are allowed in chapter titles.
Emoji seem to be disallowed. It is unknown whether things like accents or smart quotes are allowed.
To be conservative, we warn if there are any non-ascii characters in the chapter title.
pull/392/head
Mike Lang 7 months ago committed by GitHub
parent cb144866a6
commit a34af372d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -825,6 +825,11 @@ function validateChapterDescription(chapterDescField) {
if (chapterDesc.indexOf("<") !== -1 || chapterDesc.indexOf(">") !== -1) { if (chapterDesc.indexOf("<") !== -1 || chapterDesc.indexOf(">") !== -1) {
chapterDescField.classList.add("input-error"); chapterDescField.classList.add("input-error");
chapterDescField.title = "Chapter description may not contain angle brackets (< or >)"; chapterDescField.title = "Chapter description may not contain angle brackets (< or >)";
} else if (Array.from(chapterDesc).some(c => c.charCodeAt(0) > 127)) { // any char is non-ascii
// We don't know what chars are safe outside the ascii range, so we just warn on any of them.
// We know emoji are not safe.
chapterDescField.classList.add("input-error");
chapterDescField.title = "Chapter descriptions with non-ascii characters may cause issues; proceed with caution";
} else { } else {
chapterDescField.classList.remove("input-error"); chapterDescField.classList.remove("input-error");
chapterDescField.title = ""; chapterDescField.title = "";

Loading…
Cancel
Save