database: Add constraints on edit inputs that they must be non-NULL if state != UNEDITED

This should help prevent changing state to EDITED with any of these fields unset,
which would blow up the cutter.

We also fix up upload_location, which was set up as a sheet input (NOT NULL DEFAULT ''),
and add a similar constraint saying any DONE columns must have non-NULL video link.

DATABASE.md

@@ -134,7 +134,7 @@ columns                    | type                               | role        |
 `notes`                    | `TEXT NOT NULL DEFAULT ''`         | sheet input | Private notes on this event, used eg. to leave messages or special instructions. Displayed to the editor during editing, but otherwise unused.
 `allow_holes`              | `BOOLEAN NOT NULL DEFAULT FALSE`   | edit input  | If false, any missing segments encountered while cutting will cause the cut to fail. Setting this to true should be done by an operator to indicate that holes are expected in this range. It is also the operator's responsibility to ensure that all allowed cutters have all segments that they can get, since there is no guarentee that only the cutter with the least missing segments will get the cut job.
 `uploader_whitelist`       | `TEXT[]`                           | edit input  | List of uploaders which are allowed to cut this entry, or NULL to indicate no restriction. This is useful if you are allowing holes and the amount of missing data differs between nodes (this shouldn't happen - this would mean replication is also failing), or if an operator is investigating a problem with a specific node.
-`upload_location`          | `TEXT NOT NULL DEFAULT ''`         | edit input | The upload location to upload the cut video to. This is used by the cutter, and must match one of the cutter's configured upload locations. If it does not, the cutter will not claim the event.
+`upload_location`          | `TEXT`                             | edit input  | The upload location to upload the cut video to. This is used by the cutter, and must match one of the cutter's configured upload locations. If it does not, the cutter will not claim the event.
 `video_start`, `video_end` | `TIMESTAMP`                        | edit input  | Start and end time of the video to cut. If already set, used as the default trim times when editing.
 `video_title`              | `TEXT`                             | edit input  | The title of the video. If already set, used as the default title when editing instead of `description`.
 `video_description`        | `TEXT`                             | edit input  | The description field of the video. If already set, used as the default description when editing instead of `description`.

common/common/database.py

@@ -42,18 +42,18 @@ CREATE TABLE IF NOT EXISTS events (
 	notes TEXT NOT NULL DEFAULT '',
 	allow_holes BOOLEAN NOT NULL DEFAULT FALSE,
 	uploader_whitelist TEXT[],
-	upload_location TEXT NOT NULL DEFAULT '',
+	upload_location TEXT CHECK (state = 'UNEDITED' OR upload_location IS NOT NULL),
-	video_start TIMESTAMP,
+	video_start TIMESTAMP CHECK (state = 'UNEDITED' OR video_start IS NOT NULL),
-	video_end TIMESTAMP,
+	video_end TIMESTAMP CHECK (state = 'UNEDITED' OR video_end IS NOT NULL),
-	video_title TEXT,
+	video_title TEXT CHECK (state = 'UNEDITED' OR video_title IS NOT NULL),
-	video_description TEXT,
+	video_description TEXT CHECK (state = 'UNEDITED' OR video_description IS NOT NULL),
-	video_channel TEXT,
+	video_channel TEXT CHECK (state = 'UNEDITED' OR video_channel IS NOT NULL),
 	video_quality TEXT NOT NULL DEFAULT 'source',
 	state event_state NOT NULL DEFAULT 'UNEDITED',
 	uploader TEXT,
 	error TEXT,
 	video_id TEXT,
-	video_link TEXT
+	video_link TEXT CHECK (state != 'DONE' OR video_link IS NOT NULL)
 );
 
 -- Index on state, since that's almost always what we're querying on besides id