backfiller: Fix issue with tracking metrics after get_nodes() failure

There isn't an easy, clean way to pass in the DB hostname there,
and neither label is very valuable. Let's just drop it entirely.
pull/142/head
Mike Lang 5 years ago
parent 6c6c1ae637
commit ff18c7df54

@ -45,7 +45,6 @@ hash_mismatches = prom.Counter(
node_list_errors = prom.Counter( node_list_errors = prom.Counter(
'node_list_errors', 'node_list_errors',
'Number of errors fetching a list of nodes', 'Number of errors fetching a list of nodes',
['filename', 'database'],
) )
backfill_errors = prom.Counter( backfill_errors = prom.Counter(
@ -321,7 +320,7 @@ class BackfillerManager(object):
failures += 1 failures += 1
delay = common.jitter(TIMEOUT * 2**failures) delay = common.jitter(TIMEOUT * 2**failures)
self.logger.exception('Getting nodes failed. Retrying in {:.0f} s'.format(delay)) self.logger.exception('Getting nodes failed. Retrying in {:.0f} s'.format(delay))
node_list_errors.labels(filename=self.node_file).inc() node_list_errors.inc()
self.stopping.wait(delay) self.stopping.wait(delay)
continue continue
exisiting_nodes = set(self.workers.keys()) exisiting_nodes = set(self.workers.keys())

Loading…
Cancel
Save